third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp - Issue 1473103002: Generate correct error from WEBGL_draw_buffers extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp

Issue 1473103002: Generate correct error from WEBGL_draw_buffers extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp b/third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp

index 8702f1330749ded6f137dc47c72c457291885a47..11de49278c2f96e477af434a13f20ea73d99d18f 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp

@@ -72,7 +72,7 @@ void WebGLDrawBuffers::drawBuffersWEBGL(const Vector<GLenum>& buffers)

const GLenum* bufs = buffers.data();

if (!scoped.context()->m_framebufferBinding) {

if (n != 1) {

- scoped.context()->synthesizeGLError(GL_INVALID_VALUE, "drawBuffersWEBGL", "more than one buffer");

+ scoped.context()->synthesizeGLError(GL_INVALID_OPERATION, "drawBuffersWEBGL", "must provide exactly one buffer");

return;

}

if (bufs[0] != GL_BACK && bufs[0] != GL_NONE) {

« no previous file with comments | « content/test/gpu/gpu_tests/webgl_conformance_expectations.py ('k') | no next file » | no next file with comments »