Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1473093002: Improve tracing for sibling style invalidation (Closed)

Created:
5 years ago by Eric Willigers
Modified:
5 years ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve tracing for sibling style invalidation The trace event is associated with the element that was updated, instead of incorrectly being associated with the element's parent. BUG=378135 Committed: https://crrev.com/1b59e494cf771a62a65c9fec8dec485b4c487bb4 Cr-Commit-Position: refs/heads/master@{#361292}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 4 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Eric Willigers
Fix requested in the review comment https://codereview.chromium.org/1317533002/diff/690001/third_party/WebKit/Source/core/css/RuleFeature.cpp#newcode604
5 years ago (2015-11-24 01:58:20 UTC) #2
Timothy Loh
lgtm
5 years ago (2015-11-24 03:15:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473093002/1
5 years ago (2015-11-24 03:23:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/133420)
5 years ago (2015-11-24 05:06:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473093002/1
5 years ago (2015-11-24 08:16:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 08:44:37 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-24 08:45:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b59e494cf771a62a65c9fec8dec485b4c487bb4
Cr-Commit-Position: refs/heads/master@{#361292}

Powered by Google App Engine
This is Rietveld 408576698