Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: third_party/WebKit/Source/core/css/RuleFeature.cpp

Issue 1473093002: Improve tracing for sibling style invalidation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/RuleFeature.cpp
diff --git a/third_party/WebKit/Source/core/css/RuleFeature.cpp b/third_party/WebKit/Source/core/css/RuleFeature.cpp
index 75a438c2cd8c019949eb4749be97435e2192f812..b3aea5071d480bc51529941dba44bd6488582912 100644
--- a/third_party/WebKit/Source/core/css/RuleFeature.cpp
+++ b/third_party/WebKit/Source/core/css/RuleFeature.cpp
@@ -608,8 +608,7 @@ void RuleFeatureSet::collectInvalidationSetsForClass(InvalidationLists& invalida
invalidationLists.descendants.append(invalidationData->descendants());
}
if (invalidationData->siblings()) {
- if (element.parentElement())
- TRACE_SCHEDULE_STYLE_INVALIDATION(*element.parentElement(), *invalidationData->siblings(), classChange, className);
+ TRACE_SCHEDULE_STYLE_INVALIDATION(element, *invalidationData->siblings(), classChange, className);
invalidationLists.siblings.append(invalidationData->siblings());
}
}
@@ -623,8 +622,7 @@ void RuleFeatureSet::collectInvalidationSetsForId(InvalidationLists& invalidatio
invalidationLists.descendants.append(invalidationData->descendants());
}
if (invalidationData->siblings()) {
- if (element.parentElement())
- TRACE_SCHEDULE_STYLE_INVALIDATION(*element.parentElement(), *invalidationData->siblings(), idChange, id);
+ TRACE_SCHEDULE_STYLE_INVALIDATION(element, *invalidationData->siblings(), idChange, id);
invalidationLists.siblings.append(invalidationData->siblings());
}
}
@@ -638,8 +636,7 @@ void RuleFeatureSet::collectInvalidationSetsForAttribute(InvalidationLists& inva
invalidationLists.descendants.append(invalidationData->descendants());
}
if (invalidationData->siblings()) {
- if (element.parentElement())
- TRACE_SCHEDULE_STYLE_INVALIDATION(*element.parentElement(), *invalidationData->siblings(), attributeChange, attributeName);
+ TRACE_SCHEDULE_STYLE_INVALIDATION(element, *invalidationData->siblings(), attributeChange, attributeName);
invalidationLists.siblings.append(invalidationData->siblings());
}
}
@@ -653,8 +650,7 @@ void RuleFeatureSet::collectInvalidationSetsForPseudoClass(InvalidationLists& in
invalidationLists.descendants.append(invalidationData->descendants());
}
if (invalidationData->siblings()) {
- if (element.parentElement())
- TRACE_SCHEDULE_STYLE_INVALIDATION(*element.parentElement(), *invalidationData->siblings(), pseudoChange, pseudo);
+ TRACE_SCHEDULE_STYLE_INVALIDATION(element, *invalidationData->siblings(), pseudoChange, pseudo);
invalidationLists.siblings.append(invalidationData->siblings());
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698