components/offline_pages/offline_page_model.h - Issue 1473043002: [Offline pages] Fixing a crash in URL change, when offline copy not present

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model.h

Issue 1473043002: [Offline pages] Fixing a crash in URL change, when offline copy not present (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding tests for 2 crashing bugs Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/offline_pages/offline_page_model.h

diff --git a/components/offline_pages/offline_page_model.h b/components/offline_pages/offline_page_model.h

index c6e93f2ed9fe18b387ab92a46c0bf9a9b9914f3a..3dc8d02b9af672def08543258e79e19825ffe25e 100644

--- a/components/offline_pages/offline_page_model.h

+++ b/components/offline_pages/offline_page_model.h

@@ -201,6 +201,7 @@ class OfflinePageModel : public KeyedService,

private:

FRIEND_TEST_ALL_PREFIXES(OfflinePageModelTest, MarkPageForDeletion);

+ FRIEND_TEST_ALL_PREFIXES(OfflinePageModelTest, BookmarkNodeChangesUrl);

typedef ScopedVector<OfflinePageArchiver> PendingArchivers;

« no previous file with comments | « no previous file | components/offline_pages/offline_page_model.cc » ('j') | no next file with comments »