Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Side by Side Diff: components/offline_pages/offline_page_model.h

Issue 1473043002: [Offline pages] Fixing a crash in URL change, when offline copy not present (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding tests for 2 crashing bugs Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/offline_pages/offline_page_model.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_H_ 5 #ifndef COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_H_
6 #define COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_H_ 6 #define COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 // observers. 194 // observers.
195 void CheckForExternalFileDeletion(); 195 void CheckForExternalFileDeletion();
196 196
197 // Methods for testing only: 197 // Methods for testing only:
198 OfflinePageMetadataStore* GetStoreForTesting(); 198 OfflinePageMetadataStore* GetStoreForTesting();
199 199
200 bool is_loaded() const { return is_loaded_; } 200 bool is_loaded() const { return is_loaded_; }
201 201
202 private: 202 private:
203 FRIEND_TEST_ALL_PREFIXES(OfflinePageModelTest, MarkPageForDeletion); 203 FRIEND_TEST_ALL_PREFIXES(OfflinePageModelTest, MarkPageForDeletion);
204 FRIEND_TEST_ALL_PREFIXES(OfflinePageModelTest, BookmarkNodeChangesUrl);
204 205
205 typedef ScopedVector<OfflinePageArchiver> PendingArchivers; 206 typedef ScopedVector<OfflinePageArchiver> PendingArchivers;
206 207
207 // BaseBookmarkModelObserver: 208 // BaseBookmarkModelObserver:
208 void BookmarkModelChanged() override; 209 void BookmarkModelChanged() override;
209 void BookmarkNodeAdded(bookmarks::BookmarkModel* model, 210 void BookmarkNodeAdded(bookmarks::BookmarkModel* model,
210 const bookmarks::BookmarkNode* parent, 211 const bookmarks::BookmarkNode* parent,
211 int index) override; 212 int index) override;
212 void BookmarkNodeRemoved(bookmarks::BookmarkModel* model, 213 void BookmarkNodeRemoved(bookmarks::BookmarkModel* model,
213 const bookmarks::BookmarkNode* parent, 214 const bookmarks::BookmarkNode* parent,
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 scoped_observer_; 311 scoped_observer_;
311 312
312 base::WeakPtrFactory<OfflinePageModel> weak_ptr_factory_; 313 base::WeakPtrFactory<OfflinePageModel> weak_ptr_factory_;
313 314
314 DISALLOW_COPY_AND_ASSIGN(OfflinePageModel); 315 DISALLOW_COPY_AND_ASSIGN(OfflinePageModel);
315 }; 316 };
316 317
317 } // namespace offline_pages 318 } // namespace offline_pages
318 319
319 #endif // COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_H_ 320 #endif // COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_H_
OLDNEW
« no previous file with comments | « no previous file | components/offline_pages/offline_page_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698