Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_fyi_Mac_OpenSSL.json

Issue 1472893002: chromium_tests: require explicit compile targets (except for Android) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium.expected/full_chromium_fyi_Mac_OpenSSL.json
diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Mac_OpenSSL.json b/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Mac_OpenSSL.json
index 85d8643434e9089d0b2a288d304cfd3408ab27c8..8d1b9edcf6695a7e314976a6b5ae100bb1398f5b 100644
--- a/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Mac_OpenSSL.json
+++ b/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Mac_OpenSSL.json
@@ -149,56 +149,22 @@
"name": "cleanup_temp"
},
{
- "allow_subannotations": true,
"cmd": [
"python",
"-u",
- "[BUILD]/scripts/slave/clang_revision.py",
- "--src-dir",
- "[SLAVE_BUILD]/src",
- "--output-json",
- "/path/to/tmp/json"
- ],
- "cwd": "[SLAVE_BUILD]",
- "name": "clang_revision",
- "~followup_annotations": [
- "@@@STEP_LOG_LINE@json.output@{@@@",
- "@@@STEP_LOG_LINE@json.output@ \"clang_revision\": \"123456-7\"@@@",
- "@@@STEP_LOG_LINE@json.output@}@@@",
- "@@@STEP_LOG_END@json.output@@@"
- ]
- },
- {
- "cmd": [
- "python",
- "-u",
- "[BUILD]/scripts/slave/compile.py",
- "--target",
- "Release",
- "--src-dir",
- "[SLAVE_BUILD]/src",
- "--build-tool",
- "ninja",
- "--compiler",
- "goma-clang",
- "--goma-jsonstatus",
- "/path/to/tmp/json",
- "--goma-dir",
- "[BUILD]/goma",
- "--",
- "All",
- "chromium_builder_tests"
+ "import sys; sys.exit(1)"
],
"cwd": "[SLAVE_BUILD]",
"name": "compile",
"~followup_annotations": [
- "@@@STEP_LOG_LINE@json.output (invalid)@null@@@",
- "@@@STEP_LOG_END@json.output (invalid)@@@"
+ "step returned non-zero exit code: 1",
+ "@@@STEP_TEXT@Please add explicit compile targets for the build@@@",
+ "@@@STEP_FAILURE@@@"
]
},
{
"name": "$result",
- "recipe_result": null,
- "status_code": 0
+ "reason": "Step('compile') failed with return_code 1",
+ "status_code": 1
}
]

Powered by Google App Engine
This is Rietveld 408576698