chromium_tests: require explicit compile targets (except for Android)

scripts/slave/recipes/chromium.expected/full_chromium_Linux_x64.json

Index: scripts/slave/recipes/chromium.expected/full_chromium_Linux_x64.json
diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_Linux_x64.json b/scripts/slave/recipes/chromium.expected/full_chromium_Linux_x64.json
index 641fff5d378f6b4455ffd8ce11a61732c801a17f..2a07e6cf37a60e7a26bc7a05ffa899fcb0ac63f7 100644
--- a/scripts/slave/recipes/chromium.expected/full_chromium_Linux_x64.json
+++ b/scripts/slave/recipes/chromium.expected/full_chromium_Linux_x64.json
@@ -153,71 +153,19 @@
     "cmd": [
       "python",
       "-u",
-      "[SLAVE_BUILD]/src/tools/mb/mb.py",
-      "gen",
-      "-m",
-      "chromium",
-      "-b",
-      "Linux x64",
-      "--config-file",
-      "[SLAVE_BUILD]/src/tools/mb/mb_config.pyl",
-      "--goma-dir",
-      "[BUILD]/goma",
-      "//out/Release"
-    ],
-    "cwd": "[SLAVE_BUILD]",
-    "name": "generate_build_files"
-  },
-  {
-    "cmd": [
-      "python",
-      "-u",
-      "[BUILD]/scripts/slave/compile.py",
-      "--target",
-      "Release",
-      "--src-dir",
-      "[SLAVE_BUILD]/src",
-      "--build-tool",
-      "ninja",
-      "--compiler",
-      "goma",
-      "--goma-jsonstatus",
-      "/path/to/tmp/json",
-      "--goma-dir",
-      "[BUILD]/goma",
-      "--ninja-ensure-up-to-date",
-      "--clobber",
-      "--",
-      "All",
-      "chromium_builder_tests"
+      "import sys; sys.exit(1)"
     ],
     "cwd": "[SLAVE_BUILD]",
     "name": "compile",
     "~followup_annotations": [
-      "@@@STEP_LOG_LINE@json.output (invalid)@null@@@",
-      "@@@STEP_LOG_END@json.output (invalid)@@@"
+      "step returned non-zero exit code: 1",
+      "@@@STEP_TEXT@Please add explicit compile targets for the build@@@",

[Nico, 2015/11/23 16:20:04]

This is the main waterfall Linux x64 clobber bot, right? That should probably
get an explicit target 'all' (or 'gn_all') target first?


...oh, it looks like something does pass gn_all for this bot, I suppose
https://code.google.com/p/chromium/codesearch#chromium/src/testing/buildbot/c...

So as long that is parsed before the recipes run I suppose things should be
fine.

But it looks like the testing logic does inject dummy test targets (see All and
chromium_builder tests in this file on the lhs, and see
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...
and
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...).
I suppose the test targets injected by src/testing/buildbot are processed
earlier? Do we still need default_targets in recipes after this change? It
shouldn't be used anywhere any more, right?

Why does Linux x64 get this error in its expectations file but Linux (the 32-bit
one) doesn't?

It's very very unfortunate that the golden files don't know about these targets
-- can you remind me where the "move recipes to src/" bug is again?

[Dirk Pranke, 2015/11/24 01:54:22]

I think the expectations are using the wrong test data at the moment, and as a
result
we're not really seeing the correct thing here. I think this got "broken" in 

https://codereview.chromium.org/1466563002/

and I need to fix it.
It is still used. I would like to get rid of these where possible and have the
targets only live src-side.
Those have two different configs (Linux is still not using MB or GN).
Agreed I think we need to clean up the golden files before landing this.
I believe that's crbug.com/459840.

+      "@@@STEP_FAILURE@@@"
     ]
   },
   {
-    "cmd": [
-      "python",
-      "-u",
-      "[BUILD]/scripts/slave/chromium/archive_build.py",
-      "--target",
-      "Release",
-      "--factory-properties",
-      "{\"gclient_env\": {\"GYP_DEFINES\": \"component=static_library gomadir='[BUILD]/goma' linux_dump_symbols=0 target_arch=x64 test_isolation_mode=noop use_goma=1\"}, \"gs_acl\": \"public-read\", \"gs_bucket\": \"gs://chromium-browser-snapshots\"}",
-      "--build-properties",
-      "{\"got_angle_revision\": \"fac9503c46405f77757b9a728eb85b8d7bc6080c\", \"got_angle_revision_cp\": \"refs/heads/master@{#297276}\", \"got_nacl_revision\": \"d998e125e8253980d76e269b7982aeeefc1b9b50\", \"got_nacl_revision_cp\": \"refs/heads/master@{#274981}\", \"got_revision\": \"f27fede2220bcd326aee3e86ddfd4ebd0fe58cb9\", \"got_revision_cp\": \"refs/heads/master@{#170242}\", \"got_swarming_client_revision\": \"a0ee5d99f1d4b38ddaa4c759c837980b63b99566\", \"got_swarming_client_revision_cp\": \"refs/heads/master@{#276089}\", \"got_v8_revision\": \"801ada225ddc271c132c3a35f03975671d43e399\", \"got_v8_revision_cp\": \"refs/heads/master@{#43426}\", \"got_webrtc_revision\": \"0f90628433546e61d9268596da93418c623137f4\", \"got_webrtc_revision_cp\": \"refs/heads/master@{#120644}\"}",
-      "--mode",
-      "dev"
-    ],
-    "cwd": "[SLAVE_BUILD]",
-    "name": "archive_build"
-  },
-  {
     "name": "$result",
-    "recipe_result": null,
-    "status_code": 0
+    "reason": "Step('compile') failed with return_code 1",
+    "status_code": 1
   }
 ]