Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_fyi_CFI_Linux.json

Issue 1472893002: chromium_tests: require explicit compile targets (except for Android) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium.expected/full_chromium_fyi_CFI_Linux.json
diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CFI_Linux.json b/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CFI_Linux.json
index 18251b3da9f544a8e0058049f5c00b496ca08ad0..a1d09e0ca5de641817e056cd1d7814c62da253aa 100644
--- a/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CFI_Linux.json
+++ b/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CFI_Linux.json
@@ -159,48 +159,22 @@
"name": "cleanup_temp"
},
{
- "allow_subannotations": true,
"cmd": [
"python",
"-u",
- "[BUILD]/scripts/slave/clang_revision.py",
- "--src-dir",
- "[SLAVE_BUILD]/src",
- "--output-json",
- "/path/to/tmp/json"
+ "import sys; sys.exit(1)"
],
"cwd": "[SLAVE_BUILD]",
- "name": "clang_revision",
+ "name": "compile",
"~followup_annotations": [
- "@@@STEP_LOG_LINE@json.output@{@@@",
- "@@@STEP_LOG_LINE@json.output@ \"clang_revision\": \"123456-7\"@@@",
- "@@@STEP_LOG_LINE@json.output@}@@@",
- "@@@STEP_LOG_END@json.output@@@"
+ "step returned non-zero exit code: 1",
+ "@@@STEP_TEXT@Please add explicit compile targets for the build@@@",
+ "@@@STEP_FAILURE@@@"
]
},
{
- "cmd": [
- "python",
- "-u",
- "[BUILD]/scripts/slave/compile.py",
- "--target",
- "Release",
- "--src-dir",
- "[SLAVE_BUILD]/src",
- "--build-tool",
- "ninja",
- "--compiler",
- "clang",
- "--",
- "All",
- "chromium_builder_tests"
- ],
- "cwd": "[SLAVE_BUILD]",
- "name": "compile"
- },
- {
"name": "$result",
- "recipe_result": null,
- "status_code": 0
+ "reason": "Step('compile') failed with return_code 1",
+ "status_code": 1
}
]

Powered by Google App Engine
This is Rietveld 408576698