Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1472873004: Reland of Use sysroot by default for all linux builds (Closed)

Created:
5 years ago by Sam Clegg
Modified:
5 years ago
Reviewers:
Lei Zhang, Dirk Pranke, Nico
CC:
chromium-reviews, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Use sysroot by default for all linux builds (patchset #1 id:1 of https://codereview.chromium.org/1473363002/ ) Reason for revert: Couldn't reproduce the failure. Original issue's description: > Revert of Use sysroot by default for all linux builds (patchset #7 id:120001 of https://codereview.chromium.org/1464983003/ ) > > Reason for revert: > Seems to have caused issues with goma: https://code.google.com/p/chromium/issues/detail?id=560973 > > Original issue's description: > > Use sysroot by default for all linux builds > > > > Using a sysroot was already the default for official > > build and when cross compiling (e.g. arm, mips, x86-32). > > This change makes it the default in all cases. > > > > The old behavior of building against local > > system libraries can still be achieved by > > setting use_sysroot=0 > > > > BUG=504446 > > > > Committed: https://crrev.com/a931efd5dc8d8783ce73a64fc641627866b6869d > > Cr-Commit-Position: refs/heads/master@{#361197} > > TBR=dpranke@chromium.org,thestig@chromium.org,thakis@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=504446 > > Committed: https://crrev.com/05373dc078f0d5d3f2fb1398db9a4008a55d9016 > Cr-Commit-Position: refs/heads/master@{#361405} TBR=dpranke@chromium.org,thestig@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504446 Committed: https://crrev.com/964155752e49f75260e86ba824fcec81b3fd4c3d Cr-Commit-Position: refs/heads/master@{#361411}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -44 lines) Patch
M build/common.gypi View 2 chunks +10 lines, -6 lines 0 comments Download
M build/config/sysroot.gni View 2 chunks +8 lines, -12 lines 0 comments Download
M build/linux/sysroot_scripts/install-sysroot.py View 3 chunks +4 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sam Clegg
Created Reland of Use sysroot by default for all linux builds
5 years ago (2015-11-24 19:24:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472873004/1
5 years ago (2015-11-24 19:27:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 19:29:55 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-24 19:30:51 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/964155752e49f75260e86ba824fcec81b3fd4c3d
Cr-Commit-Position: refs/heads/master@{#361411}

Powered by Google App Engine
This is Rietveld 408576698