third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp - Issue 1472823002: Couple V8AbstractEventListener's lifetime to the V8 listeners lifetime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

Issue 1472823002: Couple V8AbstractEventListener's lifetime to the V8 listeners lifetime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

index d5a989d40b9c93a045ef184376ab7e9cde65df35..7ca63fd4c90de521027e905e9e28702ad5d65a5b 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

@@ -203,7 +203,7 @@ void V8LazyEventListener::prepareListenerObject(ExecutionContext* executionConte

// m_code = String();

// m_eventParameterName = String();

// m_sourceURL = String();

- setListenerObject(wrappedFunction, scriptState);

+ setListenerObject(wrappedFunction);

}

void V8LazyEventListener::fireErrorEvent(v8::Local<v8::Context> v8Context, ExecutionContext* executionContext, v8::Local<v8::Message> message)