third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp - Issue 1472823002: Couple V8AbstractEventListener's lifetime to the V8 listeners lifetime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

Issue 1472823002: Couple V8AbstractEventListener's lifetime to the V8 listeners lifetime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8EventListener.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

index 08ed5664c3d2e592eef0ab04703c1c3df501cdd6..951197af900fcc915fbd77fb1f82295ebe3b0b6b 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8EventListener.cpp

@@ -38,10 +38,9 @@

namespace blink {

-V8EventListener::V8EventListener(v8::Local<v8::Object> listener, bool isAttribute, ScriptState* scriptState)

+V8EventListener::V8EventListener(bool isAttribute, ScriptState* scriptState)

: V8AbstractEventListener(isAttribute, scriptState->world(), scriptState->isolate())

{

- setListenerObject(listener, scriptState);

}

v8::Local<v8::Function> V8EventListener::getListenerFunction(ScriptState* scriptState)