Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h

Issue 1472823002: Couple V8AbstractEventListener's lifetime to the V8 listeners lifetime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h b/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h
index 1346a11e3b7dd22b6e56c5ea5481761b64e56ec9..0466f0df090b52aafacd921635996af87ff7ae67 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h
@@ -43,12 +43,14 @@ class V8ErrorHandler final : public V8EventListener {
public:
static PassRefPtrWillBeRawPtr<V8ErrorHandler> create(v8::Local<v8::Object> listener, bool isInline, ScriptState* scriptState)
{
- return adoptRefWillBeNoop(new V8ErrorHandler(listener, isInline, scriptState));
+ RefPtrWillBeRawPtr<V8ErrorHandler> eventListener = adoptRefWillBeNoop(new V8ErrorHandler(isInline, scriptState));
+ eventListener->setListenerObject(listener);
+ return eventListener.release();
}
static void storeExceptionOnErrorEventWrapper(ScriptState*, ErrorEvent*, v8::Local<v8::Value>, v8::Local<v8::Object> creationContext);
private:
- V8ErrorHandler(v8::Local<v8::Object> listener, bool isInline, ScriptState*);
+ V8ErrorHandler(bool isInline, ScriptState*);
v8::Local<v8::Value> callListenerFunction(ScriptState*, v8::Local<v8::Value>, Event*) override;
bool shouldPreventDefault(v8::Local<v8::Value> returnValue) override;
};

Powered by Google App Engine
This is Rietveld 408576698