third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp - Issue 1472823002: Couple V8AbstractEventListener's lifetime to the V8 listeners lifetime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp

Issue 1472823002: Couple V8AbstractEventListener's lifetime to the V8 listeners lifetime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.h ('k') | third_party/WebKit/Source/bindings/core/v8/V8EventListener.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp

index e0b3f97c7d37dedabe2f7d665fd380b2214f9b56..64f574157e13db422f4e76eece86a3c0f13d3223 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ErrorHandler.cpp

@@ -42,8 +42,8 @@

namespace blink {

-V8ErrorHandler::V8ErrorHandler(v8::Local<v8::Object> listener, bool isInline, ScriptState* scriptState)

- : V8EventListener(listener, isInline, scriptState)

+V8ErrorHandler::V8ErrorHandler(bool isInline, ScriptState* scriptState)

+ : V8EventListener(isInline, scriptState)

{

}