third_party/WebKit/Source/platform/heap/ThreadState.h - Issue 1472823002: Couple V8AbstractEventListener's lifetime to the V8 listeners lifetime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/ThreadState.h

Issue 1472823002: Couple V8AbstractEventListener's lifetime to the V8 listeners lifetime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ignore self refs Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp ('K') | « third_party/WebKit/Source/platform/heap/Handle.h ('k') | third_party/WebKit/Source/platform/heap/ThreadState.cpp » ('j') | third_party/WebKit/Source/platform/heap/ThreadState.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/heap/ThreadState.h

diff --git a/third_party/WebKit/Source/platform/heap/ThreadState.h b/third_party/WebKit/Source/platform/heap/ThreadState.h

index 17bb942c3e0c86b28d4c3135d16339fb7d10283c..f691e52fc7f8456fc1e79c920a5a5b9f44d93be5 100644

--- a/third_party/WebKit/Source/platform/heap/ThreadState.h

+++ b/third_party/WebKit/Source/platform/heap/ThreadState.h

@@ -233,6 +233,8 @@ public:

bool isMainThread() const { return this == mainThreadState(); }

#if ENABLE(ASSERT)

bool checkThread() const { return m_thread == currentThread(); }

+ void incrementNumberOfSelfRefs() { ++m_numberOfSelfRefs; }

+ void decrementNumberOfSelfRefs() { --m_numberOfSelfRefs; }

#endif

void performIdleGC(double deadlineSeconds);

@@ -647,6 +649,10 @@ private:

v8::Isolate* m_isolate;

void (*m_traceDOMWrappers)(v8::Isolate*, Visitor*);

+#if ENABLE(ASSERT)

+ int m_numberOfSelfRefs;

+#endif

#if defined(ADDRESS_SANITIZER)

void* m_asanFakeStack;

#endif