third_party/WebKit/Source/platform/heap/Handle.h - Issue 1472823002: Couple V8AbstractEventListener's lifetime to the V8 listeners lifetime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/Handle.h

Issue 1472823002: Couple V8AbstractEventListener's lifetime to the V8 listeners lifetime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ignore self refs Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp ('k') | third_party/WebKit/Source/platform/heap/ThreadState.h » ('j') | third_party/WebKit/Source/platform/heap/ThreadState.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/heap/Handle.h

diff --git a/third_party/WebKit/Source/platform/heap/Handle.h b/third_party/WebKit/Source/platform/heap/Handle.h

index 64e43fd71243011277fb2052e26dfe146148b0dc..763c55e8677cc5ad1dfd355fbc4d2028895c925b 100644

--- a/third_party/WebKit/Source/platform/heap/Handle.h

+++ b/third_party/WebKit/Source/platform/heap/Handle.h

@@ -1236,6 +1236,10 @@ public:

void clear()

{

+#if ENABLE(ASSERT)

+ if (m_keepAlive)

+ ThreadState::current()->decrementNumberOfSelfRefs();

+#endif

m_keepAlive.clear();

}

@@ -1247,6 +1251,9 @@ private:

{

ASSERT(!m_keepAlive || m_keepAlive.get() == self);

m_keepAlive = self;

+#if ENABLE(ASSERT)

+ ThreadState::current()->incrementNumberOfSelfRefs();

+#endif

}

GC_PLUGIN_IGNORE("420515")