Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1472563002: Let QUIC streams write 16k before ceding. Behind FLAG_quic_batch_writes. (Closed)

Created:
5 years, 1 month ago by ianswett
Modified:
5 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@107581674
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let QUIC streams write 16k before ceding. Behind FLAG_quic_batch_writes. Changing our round robin logic to prompt a given stream until it has finished ~16k (rounding up to the max quic packet payload). Merge internal change: 107595145 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+353 lines, -81 lines) Patch
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_session.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M net/quic/quic_session_test.cc View 6 chunks +116 lines, -19 lines 0 comments Download
M net/quic/quic_write_blocked_list.h View 6 chunks +66 lines, -6 lines 0 comments Download
M net/quic/quic_write_blocked_list.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M net/quic/quic_write_blocked_list_test.cc View 6 chunks +74 lines, -24 lines 0 comments Download
M net/spdy/write_blocked_list.h View 2 chunks +50 lines, -22 lines 0 comments Download
M net/spdy/write_blocked_list_test.cc View 1 chunk +28 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
ianswett
5 years, 1 month ago (2015-11-21 19:34:00 UTC) #1
Ryan Hamilton
5 years, 1 month ago (2015-11-21 22:15:44 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698