Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1471573002: Replacing EffectivePriority with Priority for QUIC. (Closed)

Created:
5 years, 1 month ago by ianswett
Modified:
5 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@107595145
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replacing EffectivePriority with Priority for QUIC. The only place we had changing priority was "if the response headers were serialized and not sent" After we moved to having a separate headers stream we never utilized the QuicWriter's header buffer, instead passing headers directly to the QUIC layer which serialized them and sent them with their own special priority. Removing the idea of mutable priority enables having the write blocked list track stream priorty, removing SPDY-specific logic from our shared code and moving us closer to the new H2 style write scheduler logic. Merge internal change: 107610692 R=rch@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -37 lines) Patch
M net/quic/p2p/quic_p2p_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/p2p/quic_p2p_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_crypto_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_crypto_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_headers_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_headers_stream.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/quic_headers_stream_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_reliable_client_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_reliable_client_stream.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_session.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_spdy_stream.h View 2 chunks +5 lines, -8 lines 0 comments Download
M net/quic/quic_spdy_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_spdy_stream_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/reliable_quic_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/reliable_quic_stream.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
ianswett
5 years, 1 month ago (2015-11-21 20:17:01 UTC) #1
Ryan Hamilton
5 years, 1 month ago (2015-11-21 22:16:52 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698