Remove null link from "welcome to tips" default suggestion. Also make some h...

Remove null link from "welcome to tips" default suggestion.  Also make some hard-coded strings in new tab page into localizable .grd strings, and fix bug introduced in r19556.


BUG= http://crbug.com/15467
TEST= Run with new new tab page for the first time, with no tips stored in preferences.  Note that welcome tip is not a link.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19740

[arv (Not doing code reviews), 2009-06-26 23:11:00]

http://codereview.chromium.org/147247/diff/1/3
File chrome/browser/resources/new_new_tab.css (right):

http://codereview.chromium.org/147247/diff/1/3#newcode435
Line 435: .tipstitle {
.tips-title

Can't this be shared?

[Miranda Callahan, 2009-06-27 23:18:50]

On 2009/06/26 23:11:00, arv wrote:
> http://codereview.chromium.org/147247/diff/1/3
> File chrome/browser/resources/new_new_tab.css (right):
> 
> http://codereview.chromium.org/147247/diff/1/3#newcode435
> Line 435: .tipstitle {
> .tips-title
> 
> Can't this be shared?

Fixed, and changed a couple more things to improve the look and behavior of the
default title.  

(This won't be reviewable or commitable until
http://codereview.chromium.org/147226 is committed for good, though; I based it
on the file changes in that patch.)

[Miranda Callahan, 2009-06-30 19:31:09]

Erik, could you take another look at this?  I tweaked the HTML and CSS to make
the title neater, and also fixed a bug introduced in a revision last night that
had broken the TipsHandler.  (Also moved everything back to the old new_new...
versions for now.)

[arv (Not doing code reviews), 2009-06-30 20:05:40]

http://codereview.chromium.org/147247/diff/2004/3017
File chrome/browser/resources/new_new_tab.css (right):

http://codereview.chromium.org/147247/diff/2004/3017#newcode442
Line 442: .tipstitle {
.tips-title

CSS naming convention is to use dashes as word separators.

http://codereview.chromium.org/147247/diff/2004/3018
File chrome/browser/resources/new_new_tab.html (right):

http://codereview.chromium.org/147247/diff/2004/3018#newcode175
Line 175: jsdisplay="url.length>0"
"url.length" would be enough

[Miranda Callahan, 2009-06-30 20:10:08]

http://codereview.chromium.org/147247/diff/2004/3017
File chrome/browser/resources/new_new_tab.css (right):

http://codereview.chromium.org/147247/diff/2004/3017#newcode442
Line 442: .tipstitle {
On 2009/06/30 20:05:40, arv wrote:
> .tips-title
> 
> CSS naming convention is to use dashes as word separators.

Done.

http://codereview.chromium.org/147247/diff/2004/3018
File chrome/browser/resources/new_new_tab.html (right):

http://codereview.chromium.org/147247/diff/2004/3018#newcode175
Line 175: jsdisplay="url.length>0"
On 2009/06/30 20:05:40, arv wrote:
> "url.length" would be enough

Done.

[arv (Not doing code reviews), 2009-06-30 20:21:50]

LGTM