Make the new new tab page the default new tab page....

Make the new new tab page the default new tab page.

I changed the command line switch "--new-new-tab-page" to
"-new-tab-page=<path>" so we can continue to iterate.

BUG=13362
TEST=The new new tab page should be on by default.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19438

[arv (Not doing code reviews), 2009-06-26 19:23:45]

I would like to get the NNTP turned on for the next dev channel release.

[Miranda Callahan, 2009-06-26 19:32:07]

LGTM.  

I suppose we should do the same for the tips service, then, so there isn't an
empty box in the right hand corner; on the other hand, there are a few things
that need to be ironed out, and I don't think many people have tried out the
tips and suggestions as it is -- so I'm still a little wary.  Thoughts?

On 2009/06/26 19:23:45, arv wrote:
> I would like to get the NNTP turned on for the next dev channel release.

[arv (Not doing code reviews), 2009-06-26 19:35:11]

The try servers are not happy with my svn foo

svn rm new_tab.html
svn mv new_new_tab.html new_tab.html

I think I'll just have to edit the old new_tab.html. I'll do that once
everything else is OK to reduce the complications of the reviewing.

[Glen Murphy, 2009-06-26 22:51:32]

LGTM with nits

http://codereview.chromium.org/147226/diff/40/1013
File chrome/browser/browser_resources.grd (right):

http://codereview.chromium.org/147226/diff/40/1013#newcode20
Line 20: <include name="IDR_NEW_TAB_THEME_CSS"
file="resources\new_tab_theme.css" flattenhtml="true" type="BINDATA" />
flattenhtml necessary?

http://codereview.chromium.org/147226/diff/40/1017
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/147226/diff/40/1017#newcode492
Line 492: const wchar_t kNewTabPage[]                 = L"new-tab-page";
Indent doesn't match with the other '=' characters.