Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issue 147243004: Move common param trait enum's to IPC range-checked macros. (Closed)

Created:
6 years, 10 months ago by Tom Sepez
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Move common param trait enum's to IPC range-checked macros. This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250541

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M content/public/common/common_param_traits_macros.h View 1 chunk +12 lines, -6 lines 0 comments Download
M content/public/common/console_message_level.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/common/security_style.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/window_open_disposition_list.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/common/webpreferences.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Tom Sepez
Darin, please review when you get a chance. I think this falls on you because ...
6 years, 10 months ago (2014-02-11 00:46:39 UTC) #1
darin (slow to review)
LGTM We discussed writing a clang plugin to assert that LAST values are really last. ...
6 years, 10 months ago (2014-02-11 15:45:15 UTC) #2
Tom Sepez
On 2014/02/11 15:45:15, darin wrote: > LGTM > > We discussed writing a clang plugin ...
6 years, 10 months ago (2014-02-11 18:11:41 UTC) #3
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 10 months ago (2014-02-11 18:21:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/147243004/1
6 years, 10 months ago (2014-02-11 18:23:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/147243004/1
6 years, 10 months ago (2014-02-11 21:24:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/147243004/1
6 years, 10 months ago (2014-02-11 22:03:45 UTC) #7
Tom Sepez
On 2014/02/11 15:45:15, darin wrote: > LGTM > > We discussed writing a clang plugin ...
6 years, 10 months ago (2014-02-11 22:16:46 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 23:06:08 UTC) #9
Message was sent while issue was closed.
Change committed as 250541

Powered by Google App Engine
This is Rietveld 408576698