ui/base/window_open_disposition_list.h - Issue 147243004: Move common param trait enum's to IPC range-checked macros.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/base/window_open_disposition_list.h

Issue 147243004: Move common param trait enum's to IPC range-checked macros. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « content/public/common/security_style.h ('k') | webkit/common/webpreferences.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Intentionally no include guards because this file is meant to be included	5 // Intentionally no include guards because this file is meant to be included

6 // inside a macro to generate enum values.	6 // inside a macro to generate enum values.

7	7

8 WINDOW_OPEN_DISPOSITION(UNKNOWN, 0)	8 WINDOW_OPEN_DISPOSITION(UNKNOWN, 0)

9 WINDOW_OPEN_DISPOSITION(SUPPRESS_OPEN, 1)	9 WINDOW_OPEN_DISPOSITION(SUPPRESS_OPEN, 1)

10 WINDOW_OPEN_DISPOSITION(CURRENT_TAB, 2)	10 WINDOW_OPEN_DISPOSITION(CURRENT_TAB, 2)

11 // Indicates that only one tab with the url should exist in the same window.	11 // Indicates that only one tab with the url should exist in the same window.

12 WINDOW_OPEN_DISPOSITION(SINGLETON_TAB, 3)	12 WINDOW_OPEN_DISPOSITION(SINGLETON_TAB, 3)

13 WINDOW_OPEN_DISPOSITION(NEW_FOREGROUND_TAB, 4)	13 WINDOW_OPEN_DISPOSITION(NEW_FOREGROUND_TAB, 4)

14 WINDOW_OPEN_DISPOSITION(NEW_BACKGROUND_TAB, 5)	14 WINDOW_OPEN_DISPOSITION(NEW_BACKGROUND_TAB, 5)

15 WINDOW_OPEN_DISPOSITION(NEW_POPUP, 6)	15 WINDOW_OPEN_DISPOSITION(NEW_POPUP, 6)

16 WINDOW_OPEN_DISPOSITION(NEW_WINDOW, 7)	16 WINDOW_OPEN_DISPOSITION(NEW_WINDOW, 7)

17 WINDOW_OPEN_DISPOSITION(SAVE_TO_DISK, 8)	17 WINDOW_OPEN_DISPOSITION(SAVE_TO_DISK, 8)

18 WINDOW_OPEN_DISPOSITION(OFF_THE_RECORD, 9)	18 WINDOW_OPEN_DISPOSITION(OFF_THE_RECORD, 9)

19 WINDOW_OPEN_DISPOSITION(IGNORE_ACTION, 10)	19 WINDOW_OPEN_DISPOSITION(IGNORE_ACTION, 10)

	20 // Update when adding a new disposition.

	21 WINDOW_OPEN_DISPOSITION(WINDOW_OPEN_DISPOSITION_LAST, 10)

OLD	NEW