Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1472363003: XFA: More underlying types (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: More underlying types Precursor to https://codereview.chromium.org/1477583002/ Also: whitespace in fxjs_v8.h Merge where possible. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/1b2462846b5deee5b142251cbe2bb7d7c07df41b

Patch Set 1 #

Patch Set 2 : Missing include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -31 lines) Patch
M fpdfsdk/include/jsapi/fxjs_v8.h View 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/src/formfiller/FFL_FormFiller.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_TextField.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 2 chunks +7 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdfsave.cpp View 2 chunks +5 lines, -9 lines 0 comments Download
M fpdfsdk/src/fpdftext.cpp View 1 1 chunk +6 lines, -7 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
Lei, ready for review.
5 years ago (2015-11-25 20:10:35 UTC) #3
Lei Zhang
lgtm
5 years ago (2015-11-25 23:12:50 UTC) #4
Tom Sepez
5 years ago (2015-11-25 23:15:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1b2462846b5deee5b142251cbe2bb7d7c07df41b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698