Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 1472313002: Revert of base: Make shared memory backed by Mach primitives by default. (Closed)

Created:
5 years ago by Sami
Modified:
5 years ago
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of base: Make shared memory backed by Mach primitives by default. (patchset #3 id:40001 of https://codereview.chromium.org/1453383002/ ) Reason for revert: Speculative revert: 3 mac perf bots started timing out in random tests around the time this patch landed. I'll keep an eye on the waterfall and reland if things don't improve. See https://code.google.com/p/chromium/issues/detail?id=561416 for logs. Original issue's description: > base: Make shared memory backed by Mach primitives by default. > > The type of shared memory used is controlled by an A/B experiment. If the > experiment isn't present, use Mach primitives. > > BUG=466437 > > Committed: https://crrev.com/8b8e4212cef52b2cf924c27bb7c49e375306acb3 > Cr-Commit-Position: refs/heads/master@{#361249} TBR=mark@chromium.org,avi@chromium.org,erikchen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466437 Committed: https://crrev.com/3e6b742e634e657d87c3267c2a8f9158c297f801 Cr-Commit-Position: refs/heads/master@{#361630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -17 lines) Patch
M base/memory/shared_memory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M base/memory/shared_memory_mac.cc View 3 chunks +19 lines, -13 lines 0 comments Download
M base/memory/shared_memory_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/loader/resource_buffer.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sami
Created Revert of base: Make shared memory backed by Mach primitives by default.
5 years ago (2015-11-25 12:12:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472313002/1
5 years ago (2015-11-25 12:13:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 12:14:29 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3e6b742e634e657d87c3267c2a8f9158c297f801 Cr-Commit-Position: refs/heads/master@{#361630}
5 years ago (2015-11-25 12:15:28 UTC) #4
Sami
5 years ago (2015-11-26 11:41:32 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1474073002/ by skyostil@chromium.org.

The reason for reverting is: Relanding. Looks like the failures may have been
unrelated after all..

Powered by Google App Engine
This is Rietveld 408576698