base/memory/shared_memory_unittest.cc - Issue 1472313002: Revert of base: Make shared memory backed by Mach primitives by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/shared_memory_unittest.cc

Issue 1472313002: Revert of base: Make shared memory backed by Mach primitives by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/memory/shared_memory_unittest.cc

diff --git a/base/memory/shared_memory_unittest.cc b/base/memory/shared_memory_unittest.cc

index 561c065ba5015b76cab29cd00f2291bb23db03f3..37b40865cf4bb0ed5bd0f17a359f37841488743a 100644

--- a/base/memory/shared_memory_unittest.cc

+++ b/base/memory/shared_memory_unittest.cc

@@ -473,10 +473,6 @@

SharedMemoryCreateOptions options;

options.size = kTestSize;

options.executable = true;

-#if defined(OS_MACOSX) && !defined(OS_IOS)

- // The Mach functionality is tested in shared_memory_mac_unittest.cc.

- options.type = SharedMemoryHandle::POSIX;

-#endif

EXPECT_TRUE(shared_memory.Create(options));

EXPECT_TRUE(shared_memory.Map(shared_memory.requested_size()));

« no previous file with comments | « base/memory/shared_memory_mac.cc ('k') | content/browser/loader/resource_buffer.cc » ('j') | no next file with comments »