Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1472243004: Clear link element sheet before clearing ownerNode. (Closed)

Created:
5 years ago by rune
Modified:
5 years ago
Reviewers:
dstockwell, kochi
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, gavinp+prerender_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear link element sheet before clearing ownerNode. clearOwnerNode synchronously updates the list of active stylesheets, and if the m_sheet member of HTMLLinkElement is set, it is considered to be an active stylesheet. If it is later added to the StyleResolver, it will crash when ownerNode and ownerDocument are null. This was already fixed a long time ago for StyleElement in [1]. [1] https://codereview.chromium.org/13508006 R=dstockwell@chromium.org BUG=426959 Committed: https://crrev.com/c22d69c2cf412a27f10419bef5c246236b87d70c Cr-Commit-Position: refs/heads/master@{#361867}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/html/link-clear-sheet-crash.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/html/link-clear-sheet-crash-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472243004/1
5 years ago (2015-11-25 23:31:59 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ...
5 years ago (2015-11-26 01:35:31 UTC) #4
rune
5 years ago (2015-11-26 10:04:47 UTC) #6
kochi
lgtm
5 years ago (2015-11-26 10:50:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472243004/1
5 years ago (2015-11-26 10:55:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 10:59:29 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-26 11:00:33 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c22d69c2cf412a27f10419bef5c246236b87d70c
Cr-Commit-Position: refs/heads/master@{#361867}

Powered by Google App Engine
This is Rietveld 408576698