Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLLinkElement.cpp

Issue 1472243004: Clear link element sheet before clearing ownerNode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/html/link-clear-sheet-crash-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
6 * Copyright (C) 2009 Rob Buis (rwlbuis@gmail.com) 6 * Copyright (C) 2009 Rob Buis (rwlbuis@gmail.com)
7 * Copyright (C) 2011 Google Inc. All rights reserved. 7 * Copyright (C) 2011 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 585 matching lines...) Expand 10 before | Expand all | Expand 10 after
596 void LinkStyle::startLoadingDynamicSheet() 596 void LinkStyle::startLoadingDynamicSheet()
597 { 597 {
598 ASSERT(m_pendingSheetType < Blocking); 598 ASSERT(m_pendingSheetType < Blocking);
599 addPendingSheet(Blocking); 599 addPendingSheet(Blocking);
600 } 600 }
601 601
602 void LinkStyle::clearSheet() 602 void LinkStyle::clearSheet()
603 { 603 {
604 ASSERT(m_sheet); 604 ASSERT(m_sheet);
605 ASSERT(m_sheet->ownerNode() == m_owner); 605 ASSERT(m_sheet->ownerNode() == m_owner);
606 m_sheet->clearOwnerNode(); 606 m_sheet.release()->clearOwnerNode();
607 m_sheet = nullptr;
608 } 607 }
609 608
610 bool LinkStyle::styleSheetIsLoading() const 609 bool LinkStyle::styleSheetIsLoading() const
611 { 610 {
612 if (m_loading) 611 if (m_loading)
613 return true; 612 return true;
614 if (!m_sheet) 613 if (!m_sheet)
615 return false; 614 return false;
616 return m_sheet->contents()->isLoading(); 615 return m_sheet->contents()->isLoading();
617 } 616 }
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
785 removePendingSheet(); 784 removePendingSheet();
786 } 785 }
787 786
788 DEFINE_TRACE(LinkStyle) 787 DEFINE_TRACE(LinkStyle)
789 { 788 {
790 visitor->trace(m_sheet); 789 visitor->trace(m_sheet);
791 LinkResource::trace(visitor); 790 LinkResource::trace(visitor);
792 } 791 }
793 792
794 } // namespace blink 793 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/html/link-clear-sheet-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698