Review comments from https://codereview.chromium.org/1415573014/

Review comments from https://codereview.chromium.org/1415573014/

R=ortuno@chromium.org
BUG=None

Committed: https://crrev.com/a69b2e6ecb2e136c8eca57176233460a334e20da
Cr-Commit-Position: refs/heads/master@{#380229}

[scheib, 2015-11-25 00:06:32]

scheib@chromium.org changed reviewers:
+ scheib@chromium.org

[scheib, 2015-11-25 00:06:33]

LGTM

FYI ortuno OOO.

[rkc, 2015-11-25 00:48:30]

On 2015/11/25 00:06:33, scheib wrote:
> LGTM
> 
> FYI ortuno OOO.

Ah, thanks!

[rkc, 2015-11-25 00:48:34]

The CQ bit was checked by rkc@chromium.org

[commit-bot: I haz the power, 2015-11-25 00:50:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1472223002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1472223002/1

[chromium-reviews, 2015-11-25 01:07:27]

You'll need OWNERS from I think.

On Tue, Nov 24, 2015 at 4:50 PM, commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1472223002/1
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1472223002/1
>
>
> https://codereview.chromium.org/1472223002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[rkc, 2015-11-25 01:38:30]

rkc@chromium.org changed reviewers:
+ armansito@chromium.org, isherman@chromium.org

[rkc, 2015-11-25 01:38:31]

Adding Arman and Ilya for owner reviews.

[commit-bot: I haz the power, 2015-11-25 02:54:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-25 02:54:53]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Ilya Sherman, 2015-11-25 05:12:11]

histograms.xml lgtm

[ortuno, 2015-11-30 23:13:55]

lgtm

[ortuno, 2015-11-30 23:17:42]

argh forgot bluetooth_adapter_factory.cc Could you please change the TODO(rkc)
to TODO(ortuno) and point to this issue: http://crbug.com/563741

[scheib, 2016-01-29 04:57:16]

Nudge, is this patch still viable?

[rkc, 2016-01-29 09:07:38]

Should be.

[scheib, 2016-01-29 17:56:44]

On 2016/01/29 09:07:38, Rahul Chaturvedi wrote:
> Should be.

Would you update TODOs per ortuno's request and land?

[ortuno, 2016-01-29 17:58:26]

On 2016/01/29 at 17:56:44, scheib wrote:
> On 2016/01/29 09:07:38, Rahul Chaturvedi wrote:
> > Should be.
> 
> Would you update TODOs per ortuno's request and land?

I don't think the TODO is valid anymore. I fixed it a while ago.

[scheib, 2016-01-29 18:07:12]

On 2016/01/29 17:58:26, ortuno wrote:
> On 2016/01/29 at 17:56:44, scheib wrote:
> > On 2016/01/29 09:07:38, Rahul Chaturvedi wrote:
> > > Should be.
> > 
> > Would you update TODOs per ortuno's request and land?
> 
> I don't think the TODO is valid anymore. I fixed it a while ago.

Well, allrighty then, let's see if it blends.

[scheib, 2016-01-29 18:07:15]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2016-01-29 18:09:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1472223002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1472223002/1

[commit-bot: I haz the power, 2016-01-29 18:14:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 18:14:56]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[scheib, 2016-03-06 01:37:50]

On 2016/01/29 18:07:12, scheib wrote:
> On 2016/01/29 17:58:26, ortuno wrote:
> > On 2016/01/29 at 17:56:44, scheib wrote:
> > > On 2016/01/29 09:07:38, Rahul Chaturvedi wrote:
> > > > Should be.
> > > 
> > > Would you update TODOs per ortuno's request and land?
> > 
> > I don't think the TODO is valid anymore. I fixed it a while ago.
> 
> Well, allrighty then, let's see if it blends.

Didn't blend. This patch does have useful fixes, however. rkc, would you merge
TOT and land?

[rkc, 2016-03-09 20:39:19]

The CQ bit was checked by rkc@chromium.org

[rkc, 2016-03-09 20:39:20]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
ortuno@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1472223002/#ps20001
(title: "merge")

[commit-bot: I haz the power, 2016-03-09 20:39:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1472223002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1472223002/20001

[commit-bot: I haz the power, 2016-03-09 21:39:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-09 21:40:15]

Description was changed from

==========
Review comments from https://codereview.chromium.org/1415573014/


R=ortuno@chromium.org
BUG=None
==========

to

==========
Review comments from https://codereview.chromium.org/1415573014/

R=ortuno@chromium.org
BUG=None

Committed: https://crrev.com/a69b2e6ecb2e136c8eca57176233460a334e20da
Cr-Commit-Position: refs/heads/master@{#380229}
==========

[commit-bot: I haz the power, 2016-03-09 21:40:17]

Patchset 2 (id:??) landed as
https://crrev.com/a69b2e6ecb2e136c8eca57176233460a334e20da
Cr-Commit-Position: refs/heads/master@{#380229}