device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h - Issue 1472223002: Review comments from https://codereview.chromium.org/1415573014/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h

Issue 1472223002: Review comments from https://codereview.chromium.org/1415573014/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/bluetooth_gatt_notify_session_bluez.h ('k') | device/bluetooth/bluetooth_remote_gatt_descriptor_bluez.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h

diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h b/device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h

index 9976975006f4f3bcaa115eff509f13af91364a5f..e46ddf9903974678918644e827f1c24e7e5d862b 100644

--- a/device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h

+++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_bluez.h

@@ -34,8 +34,8 @@ class BluetoothRemoteGattDescriptorBlueZ;

class BluetoothRemoteGattServiceBlueZ;

// The BluetoothRemoteGattCharacteristicBlueZ class implements

-// BluetoothGattCharacteristic for remote GATT characteristics on the Chrome OS

-// platform.

+// BluetoothGattCharacteristic for remote GATT characteristics for platforms

+// that use BlueZ.

class BluetoothRemoteGattCharacteristicBlueZ

: public device::BluetoothGattCharacteristic,

public bluez::BluetoothGattDescriptorClient::Observer {

@@ -134,7 +134,7 @@ class BluetoothRemoteGattCharacteristicBlueZ

bool notify_call_pending_;

// Mapping from GATT descriptor object paths to descriptor objects owned by

- // this characteristic. Since the Chrome OS implementation uses object paths

+ // this characteristic. Since the BlueZ implementation uses object paths

// as unique identifiers, we also use this mapping to return descriptors by

// identifier.

typedef std::map<dbus::ObjectPath, BluetoothRemoteGattDescriptorBlueZ*>