Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 14722017: Makes all tests (win-debug) that invoke RunExtensionSubtest (Closed)

Created:
7 years, 7 months ago by sky
Modified:
7 years, 7 months ago
Reviewers:
Matt Perry, Dan Beam
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Makes all tests (win-debug) that invoke RunExtensionSubtest ExitProcess(0). See bug for rationale. BUG=177163 TEST=none R=mpcomplete@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198890

Patch Set 1 #

Patch Set 2 : Attempt at faking sharding scripts #

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/extensions/extension_apitest.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Matt Perry
lgtm
7 years, 7 months ago (2013-05-07 21:43:03 UTC) #1
sky
I changed this so that it outputs something similar to what gtest does. This way ...
7 years, 7 months ago (2013-05-08 14:05:10 UTC) #2
sky
Committed patchset #3 manually as r198890 (presubmit successful).
7 years, 7 months ago (2013-05-08 14:11:53 UTC) #3
Matt Perry
lgtm
7 years, 7 months ago (2013-05-08 16:51:51 UTC) #4
Dan Beam
7 years, 7 months ago (2013-05-24 05:59:48 UTC) #5
Message was sent while issue was closed.
I don't know that this still works at making the win bots happy...

Powered by Google App Engine
This is Rietveld 408576698