Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: chrome/browser/extensions/extension_apitest.cc

Issue 14722017: Makes all tests (win-debug) that invoke RunExtensionSubtest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_apitest.cc
diff --git a/chrome/browser/extensions/extension_apitest.cc b/chrome/browser/extensions/extension_apitest.cc
index bb2279c9e703ea5fb0b2d24ab2e4d855d5b6cdb1..2887b5bf0498a84df1c70fd7e61942b327de3486 100644
--- a/chrome/browser/extensions/extension_apitest.cc
+++ b/chrome/browser/extensions/extension_apitest.cc
@@ -164,6 +164,14 @@ bool ExtensionApiTest::RunExtensionSubtest(const char* extension_name,
const std::string& page_url,
int flags) {
DCHECK(!page_url.empty()) << "Argument page_url is required.";
+ // See http://crbug.com/177163 for details.
+#if defined(OS_WIN) && !defined(NDEBUG)
+ LOG(WARNING) << "Workaround for 177163, prematurely stopping test";
+ // Following is necessary for sharding scripts to think the test passed.
+ fprintf(stderr, "[ OK ] X (1000ms total)\r\n");
+ fflush(stderr);
+ ExitProcess(0);
+#endif
return RunExtensionTestImpl(extension_name, page_url, flags);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698