Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1472143006: Add explicit Isolate parameter to Exception::CreateMessage() (Closed)

Created:
5 years ago by jochen (gone - plz use gerrit)
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add explicit Isolate parameter to Exception::CreateMessage() This way, we can also capture a stack trace for SMIs BUG=chromium:495801 R=yangguo@chromium.org LOG=y Committed: https://crrev.com/c47ce4cc8e0708dba27a6fce9863e7c0d3205f5d Cr-Commit-Position: refs/heads/master@{#32331}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M include/v8.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/api.cc View 1 chunk +12 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
5 years ago (2015-11-26 10:54:26 UTC) #1
Yang
On 2015/11/26 10:54:26, jochen wrote: lgtm.
5 years ago (2015-11-26 10:55:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472143006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472143006/1
5 years ago (2015-11-26 10:55:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 11:21:28 UTC) #5
commit-bot: I haz the power
5 years ago (2015-11-26 11:21:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c47ce4cc8e0708dba27a6fce9863e7c0d3205f5d
Cr-Commit-Position: refs/heads/master@{#32331}

Powered by Google App Engine
This is Rietveld 408576698