include/v8.h - Issue 1472143006: Add explicit Isolate parameter to Exception::CreateMessage()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8.h

Issue 1472143006: Add explicit Isolate parameter to Exception::CreateMessage() (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/v8.h

diff --git a/include/v8.h b/include/v8.h

index c5479c518ed374fbd6c58586cef6481b3182eeb0..784bdfaf9a753d3eefd3d5924547872064434369 100644

--- a/include/v8.h

+++ b/include/v8.h

@@ -4931,7 +4931,10 @@ class V8_EXPORT Exception {

* Will try to reconstruct the original stack trace from the exception value,

* or capture the current stack trace if not available.

- static Local<Message> CreateMessage(Local<Value> exception);

+ static Local<Message> CreateMessage(Isolate* isolate, Local<Value> exception);

+ V8_DEPRECATE_SOON(

+ "Use version with an Isolate*",

+ static Local<Message> CreateMessage(Local<Value> exception));

/**

* Returns the original stack trace that was captured at the creation time

« no previous file with comments | « no previous file | src/api.cc » ('j') | no next file with comments »