Issue 1471953002: When deciding not to walk the native stack, don't overwrite the vm_tag set in SetupSample.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1471953002: When deciding not to walk the native stack, don't overwrite the vm_tag set in SetupSample. (Closed)

Created:
5 years, 1 month ago by rmacnak

Modified:
5 years ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch, srdjan

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

When deciding not to walk the native stack, don't overwrite the vm_tag set in SetupSample. This causes ticks in the precompiler on a Mac to be correctly bucketed under Compile, VM, etc instead of Embedder. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/5b57280d5e0002469131d5c7f5a858928aef5723

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
	M	runtime/vm/profiler.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download
	M	runtime/vm/profiler_test.cc	View	1	4 chunks	+8 lines, -8 lines	0 comments	Download

Total messages: 6 (1 generated)

rmacnak

This seems to break filtering in the allocation sample unit tests though...

5 years ago (2015-11-24 00:25:27 UTC) #3

rmacnak

Updated test filter to filter the VM tag instead of the Embedder tag. PTAL.

5 years ago (2015-11-24 21:14:42 UTC) #4

rmacnak

5 years ago (2015-11-24 23:36:58 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
5b57280d5e0002469131d5c7f5a858928aef5723 (presubmit successful).