Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: runtime/vm/profiler_test.cc

Issue 1471953002: When deciding not to walk the native stack, don't overwrite the vm_tag set in SetupSample. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/profiler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/profiler_test.cc
diff --git a/runtime/vm/profiler_test.cc b/runtime/vm/profiler_test.cc
index 7ed4c361afddfcdfff9f0afbf1469364d71adfe2..a35da3071634f32f9877c99b8b2a98fbda10b39b 100644
--- a/runtime/vm/profiler_test.cc
+++ b/runtime/vm/profiler_test.cc
@@ -152,12 +152,12 @@ class AllocationFilter : public SampleFilter {
explicit AllocationFilter(Isolate* isolate, intptr_t cid)
: SampleFilter(isolate),
cid_(cid),
- enable_embedder_ticks_(false) {
+ enable_vm_ticks_(false) {
}
bool FilterSample(Sample* sample) {
- if (!enable_embedder_ticks_ &&
- (sample->vm_tag() == VMTag::kEmbedderTagId)) {
+ if (!enable_vm_ticks_ &&
+ (sample->vm_tag() == VMTag::kVMTagId)) {
// We don't want to see embedder ticks in the test.
return false;
}
@@ -165,13 +165,13 @@ class AllocationFilter : public SampleFilter {
(sample->allocation_cid() == cid_);
}
- void set_enable_embedder_ticks(bool enable) {
- enable_embedder_ticks_ = enable;
+ void set_enable_vm_ticks(bool enable) {
+ enable_vm_ticks_ = enable;
}
private:
intptr_t cid_;
- bool enable_embedder_ticks_;
+ bool enable_vm_ticks_;
};
@@ -835,7 +835,7 @@ TEST_CASE(Profiler_ClassAllocation) {
HANDLESCOPE(thread);
Profile profile(isolate);
AllocationFilter filter(isolate, class_class.id());
- filter.set_enable_embedder_ticks(true);
+ filter.set_enable_vm_ticks(true);
profile.Build(thread, &filter, Profile::kNoTags);
// We should have one allocation sample.
EXPECT_EQ(1, profile.sample_count());
@@ -864,7 +864,7 @@ TEST_CASE(Profiler_ClassAllocation) {
HANDLESCOPE(thread);
Profile profile(isolate);
AllocationFilter filter(isolate, class_class.id());
- filter.set_enable_embedder_ticks(true);
+ filter.set_enable_vm_ticks(true);
profile.Build(thread, &filter, Profile::kNoTags);
// We should still only have one allocation sample.
EXPECT_EQ(1, profile.sample_count());
« no previous file with comments | « runtime/vm/profiler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698