Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1471543002: use pinned value during lerp for vertical gradients (Closed)

Created:
5 years, 1 month ago by reed2
Modified:
5 years, 1 month ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

use pinned value during lerp for vertical gradients slight formatting clean up on associated gm BUG=skia: Committed: https://skia.googlesource.com/skia/+/de3aac8cea8a7113f31591e6e02c51fe0ac45280

Patch Set 1 #

Patch Set 2 : add assert in lerp_color #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M gm/gradients.cpp View 1 chunk +14 lines, -13 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
reed2
ptal
5 years, 1 month ago (2015-11-21 15:48:44 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471543002/20001
5 years, 1 month ago (2015-11-21 16:01:38 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-21 16:15:08 UTC) #6
f(malita)
lgtm
5 years, 1 month ago (2015-11-22 15:36:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471543002/20001
5 years, 1 month ago (2015-11-22 15:36:54 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-22 21:00:11 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/de3aac8cea8a7113f31591e6e02c51fe0ac45280

Powered by Google App Engine
This is Rietveld 408576698