Force full invalidation after layoutScope.setNeedsLayout() in PaintLayerScrollableArea::finalizeScr…

Force full invalidation after layoutScope.setNeedsLayout() in PaintLayerScrollableArea::finalizeScrollDimensions()

This is a partial revert of https://codereview.chromium.org/799093002
which caused the bug.

This is a temporary measure to workaround crbug.com/560418
for crbug.com/535161.

BUG=535161, 560418
Committed: https://crrev.com/7bd6497afb57b760a96713f29a4dc510890e0272
Cr-Commit-Position: refs/heads/master@{#361215}

[Xianzhu, 2015-11-20 22:38:58]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, jchaffraix@chromium.org

[Xianzhu, 2015-11-20 22:38:58]

I've spent days trying to get a reduced test case and find the root cause, but
didn't get any result, so I'd like to land this partial revert to fix the bug
first, then try to fix the root cause when I have time.

[chrishtr, 2015-11-22 00:26:22]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-11-22 00:26:22]

lgtm

[commit-bot: I haz the power, 2015-11-22 00:26:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471453002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471453002/1

[commit-bot: I haz the power, 2015-11-22 01:20:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-22 01:20:27]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2015-11-23 05:08:50]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2015-11-23 05:08:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/1471453002/#ps20001
(title: "fast/repaint/destroy-scrollbar-expected.txt")

[commit-bot: I haz the power, 2015-11-23 05:09:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471453002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471453002/20001

[commit-bot: I haz the power, 2015-11-23 06:18:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 06:18:55]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Julien - ping for review, 2015-11-23 17:08:51]

This seems like a heavy handed hammer, especially considering that layout should
already force a full invalidation. Did you investigate why we need this extra
forced invalidation?

[Xianzhu, 2015-11-23 17:33:21]

On 2015/11/23 17:08:51, Julien Chaffraix - PST wrote:
> This seems like a heavy handed hammer especially considering that layout
should
> already force a full invalidation.

Now layout doesn't force a full invalidation, after my change separating layout
and invalidation requirements in about M38(?). This bug was caused by my change
https://codereview.chromium.org/799093002 that removed forced full paint
invalidation from layoutScope.setNeedsLayout(). This change is a partial revert
of that change. This is a temporary measure until slimming paint v2 resolves
this.

> Did you investigate why we need this extra
> forced invalidation?

I've spent several days on this, but haven't got a feasible measure yet. It
seems that we don't invalidate when client box rect of a box changes (e.g. when
a scrollbar is removed) under some circumstances. This will be fixed by slimming
paint v2 by detecting various box changes during painting.

[Xianzhu, 2015-11-23 17:41:01]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-23 17:41:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471453002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471453002/40001

[Xianzhu, 2015-11-23 17:59:40]

Description was changed from

==========
Force full invalidation after layoutScope.setNeedsLayout() in
PaintLayerScrollableArea::finalizeScrollDimensions()

This is a partial revert of https://codereview.chromium.org/799093002
which caused the bug.

BUG=535161
==========

to

==========
Force full invalidation after layoutScope.setNeedsLayout() in
PaintLayerScrollableArea::finalizeScrollDimensions()

This is a partial revert of https://codereview.chromium.org/799093002
which caused the bug.

This is a temporary measure to workaround crbug.com/560418
for crbug.com/535161.

BUG=535161,560418
==========

[Xianzhu, 2015-11-23 18:01:32]

Patchset #4 (id:60001) has been deleted

[Xianzhu, 2015-11-23 18:02:54]

Added a TODO:
 // TODO(wangxianzhu): Remove the following statement when paint invalidation
 // can detect client box changes. crbug.com/560418.
 box().setShouldDoFullPaintInvalidation();

And modified description to indicate that this CL is a temporary workaround.

[Julien - ping for review, 2015-11-23 18:09:31]

With the added explanations, lgtm

[Xianzhu, 2015-11-23 18:22:51]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2015-11-23 18:22:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/1471453002/#ps80001
(title: "Added a TODO")

[commit-bot: I haz the power, 2015-11-23 18:23:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471453002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471453002/80001

[commit-bot: I haz the power, 2015-11-23 21:14:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 21:14:59]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2015-11-23 21:54:31]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2015-11-23 21:55:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471453002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471453002/80001

[commit-bot: I haz the power, 2015-11-23 23:22:20]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-11-23 23:23:21]

Patchset 4 (id:??) landed as
https://crrev.com/7bd6497afb57b760a96713f29a4dc510890e0272
Cr-Commit-Position: refs/heads/master@{#361215}