Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 799093002: Don't force full invalidation of child in SubtreeLayoutScope::setNeedsLayout (Closed)

Created:
6 years ago by Xianzhu
Modified:
6 years ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't force full invalidation of child in SubtreeLayoutScope::setNeedsLayout setNeedsLayoutAndFullPaintInvalidation was when we changed not to always fully invalidate on layout. This change cleans up the one in SubtreeLayoutScope::setNeedsLayout BUG=375870, 441777 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187090

Patch Set 1 #

Patch Set 2 : TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M LayoutTests/TestExpectations View 1 2 chunks +29 lines, -1 line 0 comments Download
M Source/core/rendering/SubtreeLayoutScope.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Xianzhu
The following tests have changed paint invalidation coverage: fast/repaint/dynamic-table-vertical-alignment-change.html fast/repaint/intermediate-layout-position.html fast/repaint/repaint-table-row-in-composited-document.html svg/custom/marker-viewBox-changes.svg svg/filters/filter-refresh.svg I have ...
6 years ago (2014-12-12 23:41:54 UTC) #2
Julien - ping for review
(+Dan FYI) lgtm! There seems to be more differences but they are fairly trivial too.
6 years ago (2014-12-13 00:14:03 UTC) #4
Xianzhu
On 2014/12/13 00:14:03, Julien Chaffraix - PST wrote: > (+Dan FYI) > > lgtm! There ...
6 years ago (2014-12-13 01:44:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799093002/20001
6 years ago (2014-12-13 01:46:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/41459)
6 years ago (2014-12-13 04:40:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/799093002/20001
6 years ago (2014-12-13 05:33:31 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-13 07:55:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187090

Powered by Google App Engine
This is Rietveld 408576698