Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1471283006: TextTrackLoaderClient should not be a ResourceOwner. (Closed)

Created:
5 years ago by yhirano
Modified:
5 years ago
Reviewers:
Nate Chapin
CC:
chromium-reviews, tyoshino+watch_chromium.org, nessy, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, loading-reviews_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, Nate Chapin, vcarbune.chromium, philipj_slow
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

TextTrackLoaderClient should not be a ResourceOwner. TextTrackLoaderClient is a ResourceOwner<RawResource>, but it doesn't hold a Resource. Hence it doesn't need to inherit the class. BUG=None Committed: https://crrev.com/05ecdca0f3756eaa54ab0f0de92963e6c29535ff Cr-Commit-Position: refs/heads/master@{#363153}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/core/html/HTMLTrackElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/TextTrackLoader.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
yhirano
5 years ago (2015-11-30 06:27:55 UTC) #2
Nate Chapin
lgtm
5 years ago (2015-12-03 17:07:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471283006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471283006/20001
5 years ago (2015-12-04 03:08:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/105167)
5 years ago (2015-12-04 05:27:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471283006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471283006/20001
5 years ago (2015-12-04 05:32:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-04 06:39:07 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-04 06:40:09 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/05ecdca0f3756eaa54ab0f0de92963e6c29535ff
Cr-Commit-Position: refs/heads/master@{#363153}

Powered by Google App Engine
This is Rietveld 408576698