Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Side by Side Diff: third_party/WebKit/Source/core/loader/TextTrackLoader.h

Issue 1471283006: TextTrackLoaderClient should not be a ResourceOwner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTrackElement.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 20 matching lines...) Expand all
31 #include "core/html/track/vtt/VTTParser.h" 31 #include "core/html/track/vtt/VTTParser.h"
32 #include "platform/Timer.h" 32 #include "platform/Timer.h"
33 #include "platform/heap/Handle.h" 33 #include "platform/heap/Handle.h"
34 #include "wtf/OwnPtr.h" 34 #include "wtf/OwnPtr.h"
35 35
36 namespace blink { 36 namespace blink {
37 37
38 class Document; 38 class Document;
39 class TextTrackLoader; 39 class TextTrackLoader;
40 40
41 class TextTrackLoaderClient : public ResourceOwner<RawResource> { 41 class TextTrackLoaderClient {
42 public: 42 public:
43 ~TextTrackLoaderClient() override {} 43 virtual ~TextTrackLoaderClient() {}
44 44
45 virtual void newCuesAvailable(TextTrackLoader*) = 0; 45 virtual void newCuesAvailable(TextTrackLoader*) = 0;
46 virtual void cueLoadingCompleted(TextTrackLoader*, bool loadingFailed) = 0; 46 virtual void cueLoadingCompleted(TextTrackLoader*, bool loadingFailed) = 0;
47 virtual void newRegionsAvailable(TextTrackLoader*) = 0; 47 virtual void newRegionsAvailable(TextTrackLoader*) = 0;
48 }; 48 };
49 49
50 class TextTrackLoader final : public NoBaseWillBeGarbageCollectedFinalized<TextT rackLoader>, public ResourceOwner<RawResource>, private VTTParserClient { 50 class TextTrackLoader final : public NoBaseWillBeGarbageCollectedFinalized<TextT rackLoader>, public ResourceOwner<RawResource>, private VTTParserClient {
51 WTF_MAKE_NONCOPYABLE(TextTrackLoader); 51 WTF_MAKE_NONCOPYABLE(TextTrackLoader);
52 USING_FAST_MALLOC_WILL_BE_REMOVED(TextTrackLoader); 52 USING_FAST_MALLOC_WILL_BE_REMOVED(TextTrackLoader);
53 public: 53 public:
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 // FIXME: Remove this pointer and get the Document from m_client. 91 // FIXME: Remove this pointer and get the Document from m_client.
92 RawPtrWillBeMember<Document> m_document; 92 RawPtrWillBeMember<Document> m_document;
93 Timer<TextTrackLoader> m_cueLoadTimer; 93 Timer<TextTrackLoader> m_cueLoadTimer;
94 State m_state; 94 State m_state;
95 bool m_newCuesAvailable; 95 bool m_newCuesAvailable;
96 }; 96 };
97 97
98 } // namespace blink 98 } // namespace blink
99 99
100 #endif 100 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLTrackElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698