Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1471193003: Oilpan: Remove "this" argument of registerPreFinalizer() from documentation. (Closed)

Created:
5 years ago by Yuta Kitamura
Modified:
5 years ago
Reviewers:
haraken, oilpan-reviews, sof
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: Remove "this" argument of registerPreFinalizer() from documentation. BUG=544756 R=haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com Committed: https://crrev.com/94740e359d1173f1d262857b7ebeb7913bf2218a Cr-Commit-Position: refs/heads/master@{#361301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Yuta Kitamura
5 years ago (2015-11-24 07:08:51 UTC) #2
haraken
LGTM
5 years ago (2015-11-24 07:09:24 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471193003/1
5 years ago (2015-11-24 07:10:34 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-24 09:31:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1471193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1471193003/1
5 years ago (2015-11-24 09:42:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 09:47:17 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-24 09:48:24 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/94740e359d1173f1d262857b7ebeb7913bf2218a
Cr-Commit-Position: refs/heads/master@{#361301}

Powered by Google App Engine
This is Rietveld 408576698