third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md - Issue 1471193003: Oilpan: Remove "this" argument of registerPreFinalizer() from documentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md

Issue 1471193003: Oilpan: Remove "this" argument of registerPreFinalizer() from documentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md

diff --git a/third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md b/third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md

index 0dc0c66326c6767d678670043ba1edf62ed81c04..bd9c18e331b073323c089d3e449bd3d92ee37ace 100644

--- a/third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md

+++ b/third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md

@@ -99,7 +99,7 @@ with a destructor.

A pre-finalizer must have the following function signature: `void preFinalizer()`. You can change the function name.

A pre-finalizer must be registered in the constructor by using the following statement:

-"`ThreadState::current()->registerPreFinalizer(this, preFinalizerName);`".

+"`ThreadState::current()->registerPreFinalizer(preFinalizerName);`".

```c++

class YourClass : public GarbageCollectedFinalized<YourClass> {

@@ -107,7 +107,7 @@ class YourClass : public GarbageCollectedFinalized<YourClass> {

public:

YourClass()

{

- ThreadState::current()->registerPreFinalizer(this, dispose);

+ ThreadState::current()->registerPreFinalizer(dispose);

}

void dispose()

{

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/heap/ThreadState.h » ('j') | no next file with comments »