Removed unused include of winsock.h/inet.h from sys_byteorder.h.

Removed unused include of winsock.h/inet.h from sys_byteorder.h.

The sys_byteorder methods no longer use htonl() and friends
and so the include in not necessary.  Several files, however,
expect those system methods to be available after including
sys_byteorder.h so they have been changed to use the methods
defined within sys_byteorder.h instead.

TBR=jam
BUG=

Committed: https://crrev.com/e2452b1f6a0fd3f6ce592acc9a7741dac7c6d76a
Cr-Commit-Position: refs/heads/master@{#362179}

[bcwhite, 2015-11-25 17:41:15]

bcwhite@chromium.org changed reviewers:
+ jam@chromium.org, thakis@chromium.org

[Nico, 2015-11-25 17:45:02]

lgtm

[jam, 2015-11-30 16:35:23]

On 2015/11/25 17:45:02, Nico wrote:
> lgtm

why am I added as a reviewer?

[bcwhite, 2015-11-30 17:25:18]

On 2015/11/30 16:35:23, jam wrote:
> On 2015/11/25 17:45:02, Nico wrote:
> > lgtm
> 
> why am I added as a reviewer?

The changes propagates to a lot of places.  I'll add a bunch of individual
reviewers instead.

[bcwhite, 2015-11-30 17:26:13]

bcwhite@chromium.org changed reviewers:
- jam@chromium.org

[Nico, 2015-11-30 17:26:57]

i think jam meant that
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...
applies here

[bcwhite, 2015-11-30 17:28:57]

On 2015/11/30 17:26:57, Nico wrote:
> i think jam meant that
>
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...
> applies here

Oh, okay.  TBR=jam coming up.

[bcwhite, 2015-11-30 17:29:13]

Description was changed from

==========
Removed unused include of winsock.h/inet.h from sys_byteorder.h.

The sys_byteorder methods no longer use htonl() and friends
and so the include in not necessary.  Several files, however,
expect those system methods to be available after including
sys_byteorder.h so they have been changed to use the methods
defined within sys_byteorder.h instead.

BUG=
==========

to

==========
Removed unused include of winsock.h/inet.h from sys_byteorder.h.

The sys_byteorder methods no longer use htonl() and friends
and so the include in not necessary.  Several files, however,
expect those system methods to be available after including
sys_byteorder.h so they have been changed to use the methods
defined within sys_byteorder.h instead.

TBR=jam
BUG=
==========

[bcwhite, 2015-11-30 17:29:50]

The CQ bit was checked by bcwhite@chromium.org

[commit-bot: I haz the power, 2015-11-30 17:30:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1471073010/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1471073010/20001

[commit-bot: I haz the power, 2015-11-30 19:09:42]

Description was changed from

==========
Removed unused include of winsock.h/inet.h from sys_byteorder.h.

The sys_byteorder methods no longer use htonl() and friends
and so the include in not necessary.  Several files, however,
expect those system methods to be available after including
sys_byteorder.h so they have been changed to use the methods
defined within sys_byteorder.h instead.

TBR=jam
BUG=
==========

to

==========
Removed unused include of winsock.h/inet.h from sys_byteorder.h.

The sys_byteorder methods no longer use htonl() and friends
and so the include in not necessary.  Several files, however,
expect those system methods to be available after including
sys_byteorder.h so they have been changed to use the methods
defined within sys_byteorder.h instead.

TBR=jam
BUG=
==========

[commit-bot: I haz the power, 2015-11-30 19:09:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-30 19:10:35]

Description was changed from

==========
Removed unused include of winsock.h/inet.h from sys_byteorder.h.

The sys_byteorder methods no longer use htonl() and friends
and so the include in not necessary.  Several files, however,
expect those system methods to be available after including
sys_byteorder.h so they have been changed to use the methods
defined within sys_byteorder.h instead.

TBR=jam
BUG=
==========

to

==========
Removed unused include of winsock.h/inet.h from sys_byteorder.h.

The sys_byteorder methods no longer use htonl() and friends
and so the include in not necessary.  Several files, however,
expect those system methods to be available after including
sys_byteorder.h so they have been changed to use the methods
defined within sys_byteorder.h instead.

TBR=jam
BUG=

Committed: https://crrev.com/e2452b1f6a0fd3f6ce592acc9a7741dac7c6d76a
Cr-Commit-Position: refs/heads/master@{#362179}
==========

[commit-bot: I haz the power, 2015-11-30 19:10:35]

Patchset 2 (id:??) landed as
https://crrev.com/e2452b1f6a0fd3f6ce592acc9a7741dac7c6d76a
Cr-Commit-Position: refs/heads/master@{#362179}

[jam, 2015-12-10 23:26:15]

On 2015/11/30 17:28:57, bcwhite wrote:
> On 2015/11/30 17:26:57, Nico wrote:
> > i think jam meant that
> >
>
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...
> > applies here
> 
> Oh, okay.  TBR=jam coming up.

fwiw this should have been tbr= someone in net/owners and another person in
components/nacl and content/

[chromium-reviews, 2015-12-11 01:39:51]

Okay.  Thanks for letting me know.
-- Brian


On Thu, Dec 10, 2015 at 6:26 PM, <jam@chromium.org> wrote:

> On 2015/11/30 17:28:57, bcwhite wrote:
>
>> On 2015/11/30 17:26:57, Nico wrote:
>> > i think jam meant that
>> >
>>
>
>
>
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...
>
>> > applies here
>>
>
> Oh, okay.  TBR=jam coming up.
>>
>
> fwiw this should have been tbr= someone in net/owners and another person in
> components/nacl and content/
>
> https://codereview.chromium.org/1471073010/
>



-- 
  Brian
  bcwhite@google.com
-----------------------------------------------------------------------------------------



*Treat someone as they are and they will remain that way.Treat someone as
they can be and they will become that way.*

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.