net/spdy/spdy_framer_test.cc - Issue 1471073010: Removed unused include of winsock.h/inet.h from sys_byteorder.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_framer_test.cc

Issue 1471073010: Removed unused include of winsock.h/inet.h from sys_byteorder.h. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: include inet.h for things other than byte-swap Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/spdy/spdy_framer_test.cc

diff --git a/net/spdy/spdy_framer_test.cc b/net/spdy/spdy_framer_test.cc

index 6b5f4d1bacd5f984f17c488ec11e7b92d9bffd6a..2758b5e0840e56e84cc1a9b3f31c354e1ab595d5 100644

--- a/net/spdy/spdy_framer_test.cc

+++ b/net/spdy/spdy_framer_test.cc

@@ -5534,7 +5534,8 @@ TEST_P(SpdyFramerTest, EmptySynStream) {

TEST_P(SpdyFramerTest, SettingsFlagsAndId) {

const uint32 kId = 0x020304;

const uint32 kFlags = 0x01;

- const uint32 kWireFormat = htonl(IsSpdy2() ? 0x04030201 : 0x01020304);

+ const uint32 kWireFormat =

+ base::HostToNet32(IsSpdy2() ? 0x04030201 : 0x01020304);

SettingsFlagsAndId id_and_flags =

SettingsFlagsAndId::FromWireFormat(spdy_version_, kWireFormat);

« no previous file with comments | « net/spdy/spdy_framer.cc ('k') | net/spdy/spdy_headers_block_parser.cc » ('j') | no next file with comments »