storage/browser/fileapi/file_system_usage_cache.cc - Issue 1471073008: Do not do unnecessary recursive deletes for files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/browser/fileapi/file_system_usage_cache.cc

Issue 1471073008: Do not do unnecessary recursive deletes for files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: storage/browser/fileapi/file_system_usage_cache.cc

diff --git a/storage/browser/fileapi/file_system_usage_cache.cc b/storage/browser/fileapi/file_system_usage_cache.cc

index f1d3ece46011eb3489a079add1058896a40bfc57..3ef195f8b02553f33e812b31c9b920467086605b 100644

--- a/storage/browser/fileapi/file_system_usage_cache.cc

+++ b/storage/browser/fileapi/file_system_usage_cache.cc

@@ -151,7 +151,7 @@ bool FileSystemUsageCache::Delete(const base::FilePath& usage_file_path) {

TRACE_EVENT0("FileSystem", "UsageCache::Delete");

DCHECK(CalledOnValidThread());

CloseCacheFiles();

- return base::DeleteFile(usage_file_path, true);

+ return base::DeleteFile(usage_file_path, false);

}

void FileSystemUsageCache::CloseCacheFiles() {