chrome/installer/util/copy_tree_work_item_unittest.cc - Issue 1471073008: Do not do unnecessary recursive deletes for files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/copy_tree_work_item_unittest.cc

Issue 1471073008: Do not do unnecessary recursive deletes for files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/copy_tree_work_item_unittest.cc

diff --git a/chrome/installer/util/copy_tree_work_item_unittest.cc b/chrome/installer/util/copy_tree_work_item_unittest.cc

index 35cc3af70be3d413155541cf7eb28703cefca254..5d7a5e09772f73e713e3a3f51c21ec6a38474b33 100644

--- a/chrome/installer/util/copy_tree_work_item_unittest.cc

+++ b/chrome/installer/util/copy_tree_work_item_unittest.cc

@@ -560,7 +560,7 @@ TEST_F(CopyTreeWorkItemTest, DISABLED_IfNotPresentTest) {

EXPECT_FALSE(base::PathExists(backup_file));

// Now delete the destination and try copying the file again.

- base::DeleteFile(file_name_to, true);

+ base::DeleteFile(file_name_to, false);

work_item.reset(WorkItem::CreateCopyTreeWorkItem(

file_name_from, file_name_to,

temp_dir_.path(), WorkItem::IF_NOT_PRESENT,