GTK: When a browser is shown to the user, it should immediatly become the

GTK: When a browser is shown to the user, it should immediatly become the
active browser. Not doing so was breaking code that opened a new window and
then immediatly opened aditional tabs in it.

http://crbug.com/14018

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19160

[Elliot Glaysher, 2009-06-24 19:40:12]

I'd like two people or more to review this. This is a one line fix, but it may
have implications that I haven't thought out.

[Evan Stade, 2009-06-24 19:44:17]

seems ok to me

[tony, 2009-06-24 19:45:34]

The windows code does the following:
  // If the window is already visible, just activate it.
  if (frame_->GetWindow()->IsVisible()) {
    frame_->GetWindow()->Activate();
    return;
  }
Would that work for us too?

[Elliot Glaysher, 2009-06-24 19:49:25]

On 2009/06/24 19:45:34, tony wrote:
> The windows code does the following:
>   // If the window is already visible, just activate it.
>   if (frame_->GetWindow()->IsVisible()) {
>     frame_->GetWindow()->Activate();
>     return;
>   }
> Would that work for us too?

This is a separate problem. The bugs that caused this patch happen when the
window isn't visible.

[Evan Martin, 2009-06-24 20:00:36]

It seems reasonable to me.  I've never seen any ocde that makes use of the
"active" window, so I don't know what it could break.

http://codereview.chromium.org/147091/diff/1006/9
File chrome/browser/gtk/browser_window_gtk.cc (right):

http://codereview.chromium.org/147091/diff/1006/9#newcode445
Line 445: // windows, but gtk_widget_show won't show the widget (and therefore
won't
s/windows/Windows/
to make it clear that you're talking about the OS

http://codereview.chromium.org/147091/diff/1006/9#newcode448
Line 448: // the previous browser instead of the if we don't explicitly set it
here.
typo "the if"

[tony, 2009-06-24 20:20:32]

OK, LGTM with evan's nits fixed.