GTK: When a browser is shown to the user, it should immediatly become the

chrome/browser/gtk/browser_window_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/browser_window_gtk.h"
 
 #include <gdk/gdkkeysyms.h>
 #include <X11/XF86keysym.h>
 
 #include "app/resource_bundle.h"
@@ skipping 421 matching lines @@
     }
 
     custom_frame_border->RenderToWidget(widget);
   }
 
   return FALSE;  // Allow subwidgets to paint.
 }
 
 void BrowserWindowGtk::Show() {
   gtk_widget_show(GTK_WIDGET(window_));
+
+  // The Browser associated with this browser window must become the active
+  // browser at the time Show() is called. This is the natural behaviour under
+  // windows, but gtk_widget_show won't show the widget (and therefore won't

[Evan Martin, 2009/06/24 20:00:36]

s/windows/Windows/
to make it clear that you're talking about the OS

+  // call OnFocusIn()) until we return to the runloop. Therefore any calls to
+  // BrowserList::GetLastActive() (for example, in bookmark_util), will return
+  // the previous browser instead of the if we don't explicitly set it here.

[Evan Martin, 2009/06/24 20:00:36]

typo "the if"

+  BrowserList::SetLastActive(browser());
+
 #if defined(LINUX2)
   TabOverviewTypes::instance()->SetWindowType(
       GTK_WIDGET(window_), TabOverviewTypes::WINDOW_TYPE_CHROME_TOPLEVEL,
       NULL);
 #endif
 }
 
 void BrowserWindowGtk::SetBounds(const gfx::Rect& bounds) {
   gint x = static_cast<gint>(bounds.x());
   gint y = static_cast<gint>(bounds.y());
@@ skipping 853 matching lines @@
       *edge = GDK_WINDOW_EDGE_NORTH_EAST;
     } else if (y < bounds_.height() - kResizeAreaCornerSize) {
       *edge = GDK_WINDOW_EDGE_EAST;
     } else {
       *edge = GDK_WINDOW_EDGE_SOUTH_EAST;
     }
     return true;
   }
   NOTREACHED();
 }