pkg/scheduled_test/lib/src/task.dart - Issue 14706002: Always capture stack traces when running pub tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/scheduled_test/lib/src/task.dart

Issue 14706002: Always capture stack traces when running pub tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Code review changes. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/scheduled_test/lib/src/schedule_error.dart ('k') | pkg/scheduled_test/test/scheduled_test/capture_stack_traces_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/scheduled_test/lib/src/task.dart

diff --git a/pkg/scheduled_test/lib/src/task.dart b/pkg/scheduled_test/lib/src/task.dart

index 2dfc127163953bc9f2a0a5f8da82271007f5d14d..44f68332325ef8e7142d2d38a3be4db2d30cc756 100644

--- a/pkg/scheduled_test/lib/src/task.dart

+++ b/pkg/scheduled_test/lib/src/task.dart

@@ -72,7 +72,7 @@ class Task {

Task._(fn(), this.description, TaskQueue queue, this.parent, this._id)

: queue = queue,

- stackTrace = queue.captureStackTraces ? new Trace.current() : null {

+ stackTrace = new Trace.current() {

this.fn = () {

if (state != TaskState.WAITING) {

throw new StateError("Can't run $state task '$this'.");