Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: pkg/scheduled_test/test/scheduled_test/capture_stack_traces_test.dart

Issue 14706002: Always capture stack traces when running pub tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/scheduled_test/lib/src/task.dart ('k') | sdk/lib/_internal/pub/test/test_pub.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/scheduled_test/test/scheduled_test/capture_stack_traces_test.dart
diff --git a/pkg/scheduled_test/test/scheduled_test/capture_stack_traces_test.dart b/pkg/scheduled_test/test/scheduled_test/capture_stack_traces_test.dart
deleted file mode 100644
index 25bba2043ddeef010546fd1955f435a39a4d0016..0000000000000000000000000000000000000000
--- a/pkg/scheduled_test/test/scheduled_test/capture_stack_traces_test.dart
+++ /dev/null
@@ -1,53 +0,0 @@
-// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-import 'dart:async';
-import 'dart:io' hide sleep;
-
-import 'package:scheduled_test/scheduled_test.dart';
-
-import '../metatest.dart';
-import '../utils.dart';
-
-void main() {
- setUpTimeout();
-
- expectTestsPass('error includes a stack trace by default', () {
- var error;
- test('test 1', () {
- currentSchedule.onComplete.schedule(() {
- error = currentSchedule.errors.first;
- });
-
- schedule(() => throw 'error');
- });
-
- test('test 2', () {
- // There should be two stack traces: one for the thrown error, and one
- // for the failed task (which is the captured one).
- expect(error.toString(),
- stringContainsInOrder(['Stack trace:', 'Stack trace:']));
- });
- }, passing: ['test 2']);
-
- expectTestsPass('does not capture a stack trace if set to false', () {
- var errorThrown = new Object();
- var error;
- test('test 1', () {
- currentSchedule.captureStackTraces = false;
- currentSchedule.onComplete.schedule(() {
- error = currentSchedule.errors.first;
- });
-
- schedule(() => throw errorThrown);
- });
-
- test('test 2', () {
- // There should only be the stack trace for the thrown exception, but no
- // captured trace for the failed task.
- var numStackTraces = 'Stack trace:'.allMatches(error.toString()).length;
- expect(numStackTraces, equals(1));
- });
- }, passing: ['test 2']);
-}
« no previous file with comments | « pkg/scheduled_test/lib/src/task.dart ('k') | sdk/lib/_internal/pub/test/test_pub.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698