Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1470593003: Update content desciption string for bookmark button in NTP toolbar (Closed)

Created:
5 years, 1 month ago by jianli
Modified:
5 years, 1 month ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update content desciption string for bookmark button in NTP toolbar BUG=557900 Committed: https://crrev.com/44d232c33e46199f9247a68bd6cc368374367c16 Cr-Commit-Position: refs/heads/master@{#360972}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java View 1 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jianli
5 years, 1 month ago (2015-11-20 23:58:06 UTC) #2
newt (away)
lgtm with suggestion https://codereview.chromium.org/1470593003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java (right): https://codereview.chromium.org/1470593003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java#newcode46 chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java:46: ((TextView) mBookmarksButton.getChildAt(0)).setText(OfflinePageBridge.isEnabled() nit: I think it'd ...
5 years, 1 month ago (2015-11-21 00:03:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1470593003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1470593003/20001
5 years, 1 month ago (2015-11-21 00:49:21 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-21 01:05:27 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 01:06:21 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/44d232c33e46199f9247a68bd6cc368374367c16
Cr-Commit-Position: refs/heads/master@{#360972}

Powered by Google App Engine
This is Rietveld 408576698